[BREAKING] feat: stop supporting node <= 8#35
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
=========================================
Coverage ? 94.26%
=========================================
Files ? 2
Lines ? 366
Branches ? 0
=========================================
Hits ? 345
Misses ? 21
Partials ? 0
Continue to review full report at Codecov.
|
gxcsoccer
force-pushed
the
not-support-old-node
branch
from
May 15, 2018 08:51
48736c1 to
db6e0f7
Compare
Member
|
@gxcsoccer please change your commit author
|
fengmk2
reviewed
May 15, 2018
| const size = handles.size; | ||
|
|
||
| ByteBuffer.prototype[putMethod] = function (index, value) { | ||
| ByteBuffer.prototype[putMethod] = function(index, value) { |
Member
There was a problem hiding this comment.
use class style instead of prototype?
fengmk2
approved these changes
May 15, 2018
fengmk2
approved these changes
May 15, 2018
gxcsoccer
force-pushed
the
not-support-old-node
branch
from
May 16, 2018 03:01
db6e0f7 to
b30c752
Compare
gxcsoccer
force-pushed
the
not-support-old-node
branch
from
May 16, 2018 03:05
b30c752 to
f534dff
Compare
Member
Author
|
2.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.